Automatically overwrite modules as Main#195
Closed
milesfrain wants to merge 6 commits intopurescript:masterfrom
Closed
Automatically overwrite modules as Main#195milesfrain wants to merge 6 commits intopurescript:masterfrom
milesfrain wants to merge 6 commits intopurescript:masterfrom
Conversation
* Converted lots of HTML and JS code to PS * Converted from JQuery to Halogen Hooks * Using Tailwind CSS * Using webpack for dev server and minification
This was referenced Aug 4, 2020
Collaborator
|
yeah, I'd prefer to do this on the backend. |
Member
|
Done in #182 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an alternate version of #182 applied to the Halogen rewrite (#192). This version simply overwrites the module name client-side. The backend solution proposed in #182 seems more robust, so happy to go with that solution instead..
The last commit of this PR contains the relevant changes. The diff will be clearer after #194 is merged.
Example: https://try.ps.ai/?github=JordanMartinez/purescript-cookbook/master/recipes/ButtonsHalogenHooks/src/Main.purs